Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update middleware examples list #35622

Merged
merged 3 commits into from
Mar 28, 2022
Merged

Update middleware examples list #35622

merged 3 commits into from
Mar 28, 2022

Conversation

lfades
Copy link
Member

@lfades lfades commented Mar 26, 2022

Logging and analytics are not provided in vercel/examples using middleware.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@lfades
Update middleware examples list
8c34bd2 
Logging and analytics are not provided in vercel/examples using middleware.
lfades
lfades commented Mar 26, 2022
View reviewed changes
docs/api-reference/next/server.md
Comment on lines -58 to -59
An example of _why_ you would use `waitUntil()` is integrations with logging tools such as [Sentry](https://sentry.io) or [DataDog](https://www.datadoghq.com). After the response has been sent, you can send logs of response times, errors, API call durations or overall performance metrics.

Copy link
Member Author

@lfades lfades Mar 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was removed because recommending it for these use cases is not ideal for the time being.

@kodiakhq kodiakhq bot merged commit ab119bc into vercel:canary Mar 28, 2022
@lfades lfades mentioned this pull request Mar 28, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@leerob leerob Awaiting requested review from leerob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lfades @styfle @ijjk